feat(components): exclude app-header components
#2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
force-pushed
the
feat/ensure-safe-component
branch
from
6307b8a to
c67f6dc
Compare
aklkv
force-pushed
the
feat/exclude-app-header
branch
from
26716ff to
22c4ac8
Compare
alex-ju
reviewed
Mar 11, 2025
There was a problem hiding this comment.
The change makes sense to me. However, we'd need to work around a mock component that uses these exports to emulate a full-page layout. The Mock::App::Header component itself is not being used right now, so it can be commented out, but the imported type implications may cascade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Since this components were excluded from
appReexportit actually confusesembroider/viteand breaks the build. We can either exclude them completely including disabling some parts of showcase or we keep them in theappReexport🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.